Course Catalog does not respect site wide membership restriction

nrherron92 commented 3 years ago

Reproduction Steps

Create a membership
set it to site wide restriction (or just set the restriction on the course catalog page)
in an incognito tab access the course catalog

Expected Behavior

the course catalog should be restricted
you should not be able to access the courses
you should not be able to purchase the courses without being part of the membership

Actual Behavior

the course catalog is accessible
you can access the course itself
and purchase the course without being part of the restricting membership

Error Messages / Logs

Include any relevant error messages or log files


<!-- Paste error logs / backtraces below this line -->


### System and Environment Information

<details>
<summary>System Report</summary>

<!-- Paste your System Report between the three backticks below this line -->

Wordpress

Home Url: http://example.local Site Url: http://example.local Login Url: http://example.local/wp-login.php Version: 5.6 Debug Mode: No Debug Log: No Debug Display: Yes Locale: en_US Multisite: No Page For Posts: Sample Page (#2) [http://example.local/sample-page/] Page On Front: Home (#51) [http://example.local/] Permalink Structure: /%year%/%monthnum%/%day%/%postname%/ Show On Front: page Wp Cron: Yes

Settings

Version: 4.11.0 Db Version: 4.11.0 Course Catalog: Course Catalog (#5) [http://example.local/courses/] Membership Catalog: Membership Catalog (#6) [http://example.local/memberships/] Student Dashboard: Dashboard (#8) [http://example.local/dashboard/] Checkout Page: Purchase (#7) [http://example.local/purchase/] Course Catalog Per Page: 9 Course Catalog Sorting: menu_order,ASC Membership Catalog Per Page: 9 Membership Catalog Sorting: menu_order,ASC Site Membership: Membership Example (#177) [http://example.local/membership/membership-example/] Courses Endpoint: my-courses Edit Endpoint: edit-account Lost Password Endpoint: lost-password Vouchers Endpoint: redeem-voucher Autogenerate Username: yes Password Strength Meter: yes Minimum Password Strength: strong Terms Required: no Terms Page: Not Set Checkout Names: required Checkout Address: optional Checkout Phone: optional Checkout Email Confirmation: no Open Registration: no Registration Names: required Registration Address: optional Registration Phone: hidden Registration Voucher: optional Registration Email Confirmation: no Account Names: required Account Address: required Account Phone: optional Account Email Confirmation: yes Confirmation Endpoint: confirm-payment Force Ssl Checkout: no Country: US Currency: USD Currency Position: left Thousand Separator: , Decimal Separator: . Decimals: 2 Trim Zero Decimals: no Recurring Payments: yes Email From Address: yourname@yourdomain.com Email From Name: My Great Blog Email Footer Text: Email Header Image: Cert Bg Width: 800 Cert Bg Height: 616 Cert Legacy Compat: no

Gateways

Manual: Enabled Manual Logging: no Manual Order: 1

Server

Mysql Version: 5.7.25 Php Curl: Yes Php Default Timezone: UTC Php Fsockopen: Yes Php Max Input Vars: 1000 Php Max Upload Size: 8 MB Php Memory Limit: 256M Php Post Max Size: 8M Php Soap: Yes Php Suhosin: No Php Time Limt: 30 Php Version: 7.3.1 Software: Apache Wp Memory Limit: 256M

Browser

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.96 Safari/537.36

Theme

Name: Astra Version: 3.0.1 Themeuri: https://wpastra.com/ Authoruri: https://wpastra.com/about/ Template: Child Theme: No Llms Support: Yes

Plugins

LifterLMS: 4.11.0 LifterLMS Helper: 3.1.0

Integrations

BbPress: No BuddyPress: No

Template Overrides



</details>

This issue has be recreated:
+ [X] Locally
+ [X] On a staging site
+ [X] On a production website
+ [X] With only LifterLMS and a default theme

nrherron92 commented 3 years ago

HS-150898

thomasplevy commented 3 years ago

See related WIP PR at #1263

gocodebox / lifterlms