Reporting Export Ignores Leading 0 in Zipcode

nrherron92 commented 1 year ago

Reproduction Steps

HS-213290
Add an address to a user with a zip code that starts with 0
Head into reporting and export the student report

Expected Behavior

The zip code should be exported as is

Actual Behavior

Zeros are ignored at the beginning of the zip code

Error Messages / Logs

Include any relevant error messages or log files


<!-- Paste error logs / backtraces below this line -->


### System and Environment Information

<details>
<summary>System Report</summary>

<!-- Paste your System Report between the three backticks below this line -->

Wordpress

Home Url: https://natie.myliftersite.com Site Url: https://natie.myliftersite.com Login Url: https://natie.myliftersite.com/wp-login.php Version: 6.1.1 Debug Mode: Yes Debug Log: Yes Debug Display: Yes Locale: en_US Multisite: No Page For Posts: Not Set Page On Front: Not Set Permalink Structure: /%postname%/ Show On Front: posts Wp Cron: No

Settings

Version: 7.0.1 Db Version: 7.0.1 Course Catalog: Course Catalog (#120) [https://natie.myliftersite.com/courses/] Membership Catalog: Membership Catalog (#121) [https://natie.myliftersite.com/memberships/] Student Dashboard: Dashboard (#123) [https://natie.myliftersite.com/dashboard/] Checkout Page: Purchase (#122) [https://natie.myliftersite.com/purchase/] Course Catalog Per Page: 9 Course Catalog Sorting: menu_order,ASC Membership Catalog Per Page: 9 Membership Catalog Sorting: menu_order Site Membership: Not Set Courses Endpoint: my-courses Edit Endpoint: edit-account Lost Password Endpoint: lost-password Vouchers Endpoint: redeem-voucher Autogenerate Username: no Password Strength Meter: no Minimum Password Strength: Terms Required: no Terms Page: Not Set Checkout Names: Checkout Address: Checkout Phone: Checkout Email Confirmation: no Open Registration: no Registration Names: Registration Address: Registration Phone: Registration Voucher: Registration Email Confirmation: no Account Names: Account Address: Account Phone: Account Email Confirmation: no Confirmation Endpoint: confirm-payment Force Ssl Checkout: no Country: MX Currency: MXN Currency Position: left Thousand Separator: , Decimal Separator: . Decimals: 2 Trim Zero Decimals: no Recurring Payments: yes Email From Address: team+trial@lifterlms.com Email From Name: My LifterLMS Trial Site Email Footer Text: Email Header Image: Cert Bg Width: 800 Cert Bg Height: 616 Cert Legacy Compat: no

Constants

LLMS_REMOVE_ALL_DATA: undefined LLMS_REST_DISABLE: undefined LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined LLMS_SITE_IS_CLONE: undefined

Gateways

Manual: Enabled Manual Logging: no Manual Order: 1

Server

Mysql Version: 5.7.41 Php Curl: Yes Php Default Timezone: UTC Php Fsockopen: Yes Php Max Input Vars: 5000 Php Max Upload Size: 512 MB Php Memory Limit: 256M Php Post Max Size: 1024M Php Soap: Yes Php Suhosin: No Php Time Limt: 30 Php Version: 8.0.27 Software: Apache/2.4.55 (Unix) OpenSSL/1.1.1 Wp Memory Limit: 256M

Browser

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/111.0

Theme

Name: Astra Version: 4.0.2 Themeuri: https://wpastra.com/ Authoruri: https://wpastra.com/about/?utm_source=theme_preview&utm_medium=author_link&utm_campaign=astra_theme Template: Child Theme: No Llms Support: Yes

Plugins

LifterLMS: 7.0.1

Integrations

BbPress: No BuddyPress: No

Template Overrides



</details>

This issue has be recreated:
+ [x] Locally
+ [x] On a staging site
+ [x] On a production website
+ [x] With only LifterLMS and a default theme

### Browser, Device, and Operating System Information

+ Browser name and version
+ Operating System name and version
+ Device name and version (if applicable)

eri-trabiccolo commented 1 year ago

Cannot reproduce it with on that website: 28,test234@example.com,Test,Test,"January 20, 2023","January 20, 2023",0%,N/A,"123 test",,test,AGU,01293,MX,,"Mailchimp, Course Capacity/Enrollment, LifterLMS Quickstart Course",,,"MailChimp Bug, Two",,

That's what I exported.

That 01293 is correct no?

nrherron92 commented 1 year ago

Yes that 0 is correct

This is what I get:

eri-trabiccolo commented 1 year ago

How did you open it?

nrherron92 commented 1 year ago

with Numbers on mac

eri-trabiccolo commented 1 year ago

Ok I think we should export it as "01293" and not as 01293, otherwise readers get it as number.

eri-trabiccolo commented 1 year ago

@nrherron92 At the moment we’re not gonna do anything on this, there’s not an unique way to do that that will be compatible with all the importers, or their different versions. We can only inform the customer about this and tell them to make sure that when importing with Excel the Zip and phone column’s types must be set as text. The problem is not really how we export it as CSV but how Excel autodetects the column type: it thinks they're numbers hence it trims the leading zeros.

gocodebox / lifterlms