gocodebox / lifterlms

LifterLMS, a WordPress LMS Solution: Easily create, sell, and protect engaging online courses.
https://lifterlms.com
GNU General Public License v3.0
181 stars 135 forks source link

LifterLMS does not respect WordPress Dashboard > Users > Profile > Personal Options > Language when Loco Translate is used. #2459

Closed dominiquemariano closed 1 year ago

dominiquemariano commented 1 year ago

Reproduction Steps

Watch this video I recorded.

Expected Behavior

LifterLMS should respect the language set in WordPress Dashboard > Users > Profile > Personal Options > Language.

Actual Behavior

LifteLMS only respects the language set in WordPress Dashboard > Settings > General > General Settings > Site Language.

This issue has been recreated:

eri-trabiccolo commented 1 year ago

How this is related to Loco Translate?

Is this a duplicate of the following? https://github.com/gocodebox/lifterlms/issues/2324

dominiquemariano commented 1 year ago

How this is related to Loco Translate?

Is this a duplicate of the following? #2324

I used Loco Translate to translate those strings.

eri-trabiccolo commented 1 year ago

I used Loco Translate to translate those strings.

But that doesn't relate the issue to Loco Translate... You agree on that, right?

You could reproduce it by switching the user language to whatever language different than the site language. Right?

dominiquemariano commented 1 year ago

How this is related to Loco Translate?

Is this a duplicate of the following? #2324

Looks like it is a duplicate.

eri-trabiccolo commented 1 year ago

If it's a duplicate then https://github.com/gocodebox/lifterlms/pull/2326/ should fix it close as duplicate of #2324