gocodebox / lifterlms

LifterLMS, a WordPress LMS Solution: Easily create, sell, and protect engaging online courses.
https://lifterlms.com
GNU General Public License v3.0
174 stars 134 forks source link

Course Continue Button is not displayed to non-enrolled students regardless of the enrollment visibility setting. #2619

Open dominiquemariano opened 3 months ago

dominiquemariano commented 3 months ago

Reproduction Steps

  1. Create a new course.
  2. Add the Course Continue Button to the course page.
  3. Observe that the Enrollment Visibility setting is set to Everyone.

Expected Behavior

The Enrollment Visibility setting should not have Everyone in the options. Alternatively, it should not have Enrollment Visibility at all.

Actual Behavior

The Enrollment Visibility setting has Everyone in the options. But, the Course Continue Button or the Get Started button will not visible on the front-end for non-logged in users, as expected.

Since the Get Started is tied to some logic (it relies on looking up what progress the student is on the course so it knows which lesson to link to), we should make sure that the Enrollment Visibility setting does not contain Everyone as an option since that confuses users.

This issue has be recreated:

dominiquemariano commented 3 months ago

Reporting ticket is HS-240825.

shutathis commented 3 months ago

Comment from Kim:

I think we should probably rather remove the visibility setting from that block.
That block has other logic to only show if the student is enrolled. If the student isn’t enrolled, where would someone expect the button to go? We rely on looking up their progress in the course.

I have updated Expected Behavior and Actual Behavior as a result.