Open thomasplevy opened 6 years ago
@actual-saurabh, I'd like to help out on this issue and #372. Let me know if you want me to make the changes and submit a PR.
In the meantime, I have found 4 places where the date format is set to 'F j, Y':
LLMS_Shortcodes::course_info()
LLMS_Table_Achievements->get_data()
LLMS_Table_Student_Certificates->get_data()
LLMS_Order->get_access_expiration_date()
To get the WordPress general settings date format: get_option( 'date_format' )
There are also several places that use Y-m-d
as the date format string. However, I believe there is other code that relies on the date being in that format.
If the goal is to use the date format defined in general settings anytime LifterLMS displays a date, then the calls in the following need to stop passing F j, Y
to various LLMS_Order
date methods and let the default date format take over:
LLMS_Admin_Post_Table_Orders->manage_columns()
templates/myaccount/my-orders.php
templates/myaccount/view-order.php
- [ ] Access plan sale end date display
Same as issue #757, fixed by @actual-saurabh in d0ce21e424ff005269936ae95fd8e9cca014ba6e, released in 3.28.2
- [ ] Access plan sale end date display
Same as issue #757, fixed by @actual-saurabh in d0ce21e, released in 3.28.2
This is not the same issue, #757 refers to expiration end date, the note in this issue refers to the sale end date
@gocodebox/engineering please gather complicated date/time issues here. #1738 has grown complicated (see relevant comments at https://github.com/gocodebox/lifterlms/pull/1739#issuecomment-897797614)
Simpler issues with no ripple effects can be addressed as necessary but we currently don't need to start overhauling all the date functions as a result of a technically incorrect date being displayed as reported in #1738
Replacing date_i18n()
is simple on paper but becomes more complicated as you start to look into it. We'll tackle this when we have time to really focus our efforts. Today is the day. Prove me wrong if we disagree.
This issue affects HS-214507 so I closed https://github.com/gocodebox/lifterlms/issues/2448.
Strategy:
wp_date()
where possibledate_i18n()
where possibleRelated Issues