search

gocrane / crane-scheduler

Crane scheduler is a Kubernetes scheduler which can schedule pod based on actual node load.
Apache License 2.0
225 stars 64 forks source link

helm 模板文件语法错误 #15

Closed Hello-Linux closed 2 years ago

Hello-Linux commented 2 years ago

helm chart中的templates/scheduler-deployment.yaml 语法错误，if格式修复如下

containers:
      - command:
        - /scheduler
        - --leader-elect=false
        - --config=/etc/kubernetes/kube-scheduler/scheduler-config.yaml
        {{- if ge .Capabilities.KubeVersion.Minor "22" }}
        image: "{{ .Values.scheduler.image.repository }}:0.0.23"
        {{- else }}
        image: "{{ .Values.scheduler.image.repository }}:0.0.20"
        {{- end }}
Hello-Linux commented 2 years ago

@leeweir @qmhu @autumn0207 这么多天了！helm chart现在安装都会失败，都没人管的么？我滴天.............

zwForrest commented 2 years ago

@leeweir @qmhu @autumn0207 这么多天了！helm chart现在安装都会失败，都没人管的么？我滴天.............

@Hello-Linux 这个pr提了修复，但是没有动静。

autumn0207 commented 2 years ago

@zwForrest @Hello-Linux 抱歉，我前段时间一直有事，没有注意邮件...

xieydd commented 2 years ago

It is already fixed in this commit https://github.com/gocrane/helm-charts/commit/c67bf852fc8d3f64c1b2d5bb42fd8ee09276622a.

Hello-Linux commented 2 years ago

@xieydd 非常感谢