search

gocrane / crane

Crane is a FinOps Platform for Cloud Resource Analytics and Economics in Kubernetes clusters. The goal is not only to help users to manage cloud cost easier but also ensure the quality of applications.
https://gocrane.io
Apache License 2.0
1.85k stars 378 forks source link

fix recommendation feature gates #833

Closed aheizi closed 1 year ago

aheizi commented 1 year ago

What type of PR is this?

fix recommendation feature gates, crane won't loads the recommendation configuration when recommendation is trun off by feature gates

What this PR does / why we need it:

When the recommendation is turned off, it can be completely turned off

Which issue(s) this PR fixes:

Fixes #832

Special notes for your reviewer:

github-actions[bot] commented 1 year ago

🎉 Successfully Build Images. Now Support ARM Platforms. Comment Post Time: 2023-07-04 21:16 Git Version: 8b80e8f

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-833-8b80e8f docker pull gocrane/crane-agent:pr-833-8b80e8f
dashboard:pr-833-8b80e8f docker pull gocrane/dashboard:pr-833-8b80e8f
metric-adapter:pr-833-8b80e8f docker pull gocrane/metric-adapter:pr-833-8b80e8f
craned:pr-833-8b80e8f docker pull gocrane/craned:pr-833-8b80e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-833-8b80e8f \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-833-8b80e8f \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-833-8b80e8f \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-833-8b80e8f crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-833-8b80e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-833-8b80e8f
dashboard:pr-833-8b80e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-833-8b80e8f
metric-adapter:pr-833-8b80e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-833-8b80e8f
craned:pr-833-8b80e8f docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-833-8b80e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-833-8b80e8f \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-833-8b80e8f \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-833-8b80e8f \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-833-8b80e8f crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-833-8b80e8f docker pull ghcr.io/gocrane/crane/crane-agent:pr-833-8b80e8f
dashboard:pr-833-8b80e8f docker pull ghcr.io/gocrane/crane/dashboard:pr-833-8b80e8f
metric-adapter:pr-833-8b80e8f docker pull ghcr.io/gocrane/crane/metric-adapter:pr-833-8b80e8f
craned:pr-833-8b80e8f docker pull ghcr.io/gocrane/crane/craned:pr-833-8b80e8f

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-833-8b80e8f \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-833-8b80e8f \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-833-8b80e8f \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-833-8b80e8f crane/crane