search

gocrane / crane

Crane is a FinOps Platform for Cloud Resource Analytics and Economics in Kubernetes clusters. The goal is not only to help users to manage cloud cost easier but also ensure the quality of applications.
https://gocrane.io
Apache License 2.0
1.85k stars 378 forks source link

fix: Add the configuration to meet the load cpu and memory usage. Sto… #854

Open comqx opened 1 year ago

comqx commented 1 year ago

…p the recommendation

What type of PR is this?

good first issue

What this PR does / why we need it:

Fix issues

Which issue(s) this PR fixes:

Fixes # (https://github.com/gocrane/crane/issues/632)

Special notes for your reviewer:

qmhu commented 1 year ago

I think we need to define what is a stopped existing recommendation.

comqx commented 1 year ago

I understand that the load cpu and memory usage are compliant, that the recommended value is equal to the source value in running, and not written in annotations.

If so, there should be something wrong with the one I fixed. Is that what it means?

github-actions[bot] commented 1 year ago

🎉 Successfully Build Images. Now Support ARM Platforms. Comment Post Time: 2023-08-24 14:15 Git Version: cbd132d

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-854-cbd132d docker pull gocrane/crane-agent:pr-854-cbd132d
dashboard:pr-854-cbd132d docker pull gocrane/dashboard:pr-854-cbd132d
metric-adapter:pr-854-cbd132d docker pull gocrane/metric-adapter:pr-854-cbd132d
craned:pr-854-cbd132d docker pull gocrane/craned:pr-854-cbd132d

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-854-cbd132d \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-854-cbd132d \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-854-cbd132d \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-854-cbd132d crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-854-cbd132d docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-854-cbd132d
dashboard:pr-854-cbd132d docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-854-cbd132d
metric-adapter:pr-854-cbd132d docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-854-cbd132d
craned:pr-854-cbd132d docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-854-cbd132d

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-854-cbd132d \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-854-cbd132d \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-854-cbd132d \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-854-cbd132d crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-854-cbd132d docker pull ghcr.io/gocrane/crane/crane-agent:pr-854-cbd132d
dashboard:pr-854-cbd132d docker pull ghcr.io/gocrane/crane/dashboard:pr-854-cbd132d
metric-adapter:pr-854-cbd132d docker pull ghcr.io/gocrane/crane/metric-adapter:pr-854-cbd132d
craned:pr-854-cbd132d docker pull ghcr.io/gocrane/crane/craned:pr-854-cbd132d

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-854-cbd132d \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-854-cbd132d \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-854-cbd132d \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-854-cbd132d crane/crane
comqx commented 1 year ago

I think we need to define what is a stopped existing recommendation.

The operation of overwriting an existing recommendation is complete