search

gocrane / crane

Crane is a FinOps Platform for Cloud Resource Analytics and Economics in Kubernetes clusters. The goal is not only to help users to manage cloud cost easier but also ensure the quality of applications.
https://gocrane.io
Apache License 2.0
1.83k stars 377 forks source link

hpa recommender fluctuation-threshold 默认值不生效 #897

Open maoqide opened 5 months ago

maoqide commented 5 months ago

What type of PR is this?

bug fix

What this PR does / why we need it:

修复 hpa recommender 未在配置中指定 fluctuation-threshold 时，创建 recommend 失败的问题。

通过 RecommendationRule 创建 HPA 的 recommend 时，报错如下： E0228 11:30:47.033358 73667 manager.go:180] RecommendationRule(workloads-rule-test) Target(default/xxxxxxxxxx): recommender "HPA" failed at recommend policy phase: HPA checkFluctuation failed: strconv.ParseFloat: parsing "": invalid syntax

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions[bot] commented 5 months ago

🎉 Successfully Build Images. Now Support ARM Platforms. Comment Post Time: 2024-02-28 11:59 Git Version: 61d8197

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-897-61d8197 docker pull gocrane/crane-agent:pr-897-61d8197
dashboard:pr-897-61d8197 docker pull gocrane/dashboard:pr-897-61d8197
metric-adapter:pr-897-61d8197 docker pull gocrane/metric-adapter:pr-897-61d8197
craned:pr-897-61d8197 docker pull gocrane/craned:pr-897-61d8197

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-897-61d8197 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-897-61d8197 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-897-61d8197 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-897-61d8197 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-897-61d8197 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-897-61d8197
dashboard:pr-897-61d8197 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-897-61d8197
metric-adapter:pr-897-61d8197 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-897-61d8197
craned:pr-897-61d8197 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-897-61d8197

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-897-61d8197 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-897-61d8197 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-897-61d8197 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-897-61d8197 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-897-61d8197 docker pull ghcr.io/gocrane/crane/crane-agent:pr-897-61d8197
dashboard:pr-897-61d8197 docker pull ghcr.io/gocrane/crane/dashboard:pr-897-61d8197
metric-adapter:pr-897-61d8197 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-897-61d8197
craned:pr-897-61d8197 docker pull ghcr.io/gocrane/crane/craned:pr-897-61d8197

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-897-61d8197 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-897-61d8197 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-897-61d8197 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-897-61d8197 crane/crane