search

gocsaf / csaf

Tools to download or provide CSAF (Common Security Advisory Framework) documents.
https://csaf.io
42 stars 25 forks source link

Improve error message if filename does not match document/tracking/id and let it be reported by the proper reporter #382

Closed JanHoefelmeyer closed 1 year ago

JanHoefelmeyer commented 1 year ago

Solves https://github.com/csaf-poc/csaf_distribution/issues/380

JanHoefelmeyer commented 1 year ago

This might be unrelated (or fixed by #357) - but if I try this PR with an empty ROLIE feed. I get a memory access violation:

roliecheck.go:247
processor.go:977
processor.go:322
processor.go:243
main.go:151
main.go:174

Maybe something is not initialized yet?

The branch seems to be based off of an older version (1 commit ahead, 41 behind main) which still has that error not yet fixed. The changes within this PR do not actually change anything that should be able to break something elsewhere.

They only rephrase an error message and use a different reporter. To be on the safe side, I merged main into this branch, which - on my side at least - fixes this error.

tschmidtb51 commented 1 year ago

@s-l-teichmann ready for review