Closed juan131 closed 12 months ago
cc @tschmidtb51 @mpermar
Thanks for the advice @tschmidtb51 ! Implemented at https://github.com/csaf-poc/csaf_distribution/pull/505/commits/4338f45b8f5f2d93f700650b40110cd1c8daab89
I'm currently on a business trip - so it might take a while for me to review it.
Friendly reminder to review this PR when you find the slot for it @tschmidtb51 Thanks in advance
Thank you for your contribution. We discussed it today.
As it basically puts the implementation of the example in a more generic case, please also adopt the example to use the new library function.
Also @s-l-teichmann had an idea about callbacks that might be helpful in the library. @s-l-teichmann please explain
Example adapted at https://github.com/csaf-poc/csaf_distribution/pull/505/commits/2e9d4ad03e8dabfb1a556126a1bb1b64ba5a3ce9 @tschmidtb51
@s-l-teichmann @tschmidtb51 friendly reminder
@s-l-teichmann Please have a look
I will have a look at this.
Looks fine to me. The only thing I don't like is the direct creation on the helpers slice. @juan131 I send https://github.com/juan131/csaf_distribution/pull/1 to your repo. But this is minor.
Thanks for the feedback @s-l-teichmann ! I applied your suggestions in the PR
Thanks everyone for you help!
Description of the change
This PR adds a new exported method to
ProductTree
type in thecsaf
package:FindProductIdentificationHelpers
. This method iterates over the product tree and find the product identification helpers associated to a given product id.Benefits
Easier to obtain product identification helpers given a product id.
Possible drawbacks
None
Applicable issues
Additional information
N/A