richtabor
commented
5 years ago Thanks for the feedback mate! Did you test the latest release, 1.5.0?
I'm actually thinking of just removing the notice altogether. 🤔
Closed pixolin closed 5 years ago
richtabor
commented
5 years ago Thanks for the feedback mate! Did you test the latest release, 1.5.0?
I'm actually thinking of just removing the notice altogether. 🤔
pixolin
commented
5 years ago Where would I find version 1.5.0? GitHub repo and WordPress directory both provide 1.1.0 currently.
I also think, nobody would miss the admin notice really. It seems so obvious you need a block editor to add blocks.
Btw, translated the plugin into German today. 🇩🇪✔️
richtabor
commented
5 years ago That's exactly what I'm thinking.
Oh sorry, I meant 1.1.0. Confused with my CoBlocks plugin. :)
And thanks! That's awesome!!
I'm testing WordPress 5.0 RC3 and just installed your new plugin.
After installation I get an admin notice, that I should run Gutenberg (which is already included in WP 5.0) and deactivate the Classic Editor (file
class-block-gallery-gutenberg-checker.php). I assume, the plugin should work in WP 5.0 without additionally running the Gutenberg plugin? Perhaps you are already working on a solution for the release tomorrow.The message to deactivate the Classic Editor is IMHO somewhat misleading. Of course I understand that I won't be able to use any blocks if I use the classic editor, but the plugin also allows to be used optionally for single posts or pages (e.g. to edit existing posts and pages in the classic editor, but create a new page with your block gallery in the new block editor). Perhaps a simple notice-info "To create gallery blocks you need to run the block editor" with an option to dismiss would be better suitable? I didn't write a pull request, as I wasn't sure about the wording and the plugin check also needs to be enhanced to check the WordPress version number.
Besides that … Damn cool stuff. Thank you for sharing. ❤️