search

godaddy-wordpress / block-gallery

WordPress gallery blocks built exclusively for Gutenberg
https://wpblockgallery.com
GNU General Public License v2.0
57 stars 13 forks source link

Add support for uploading videos #6

Closed richtabor closed 4 years ago

richtabor commented 5 years ago

After receiving feedback asking for video support, I think it'd be a good idea to implement.

I've started a new branch (image-plus-video-support) to get it started. So far, only the Stacked block is configured correctly.

Download and test the Stacked Block now.

richtabor commented 5 years ago

One issue that I have not been able to figure out yet is enabling the "Edit Gallery" button to show available videos as well. I'm not sure if that's available out of the box.

richtabor commented 5 years ago

Looks like it's related to the gallery pro for MediaUpload here. Removing it makes the images and videos both display, but the experience of using the gallery modal is so much better than the standard one.

jcklpe commented 5 years ago

Just tagging in to subscribe to this issue. Let me know if there's any thing I can do to help. I'm afraid I'm still taking my React classes so I can't contribute code directly yet but I will hopefully be able to soon!

ataylorme commented 5 years ago

The core/cover blocks allow for video as well as some nice effects like text overlay. Just thinking out loud if those could be inner blocks.

richtabor commented 5 years ago

Interesting thought @ataylorme. I guess they could, but not likely mixed in with the gallery images (only at the start and end of the gallery). The only way that'd work is if all the images were image blocks and the whole gallery is built with innerBlocks. I'm not sure if that's the best direction - but I'll look into it. 👍

seb86 commented 5 years ago

@richtabor Any further progress on this issue as I was just trying to add a video myself to the Carousel block?

richtabor commented 5 years ago

I have not put any bandwidth towards this as of late.

As I previously mentioned, we know what the issue is - I just haven’t had much time to dive into it lately.

josias-r commented 5 years ago

Any updates on this issue?