search

godaddy-wordpress / contact-widgets

Beautifully display social media and contact info on your website with these simple widgets.
https://wordpress.org/plugins/contact-widgets/
GNU General Public License v2.0
14 stars 16 forks source link

Add PHP linting #83

Closed jrtashjian closed 4 years ago

jrtashjian commented 4 years ago

All PHPCS errors are resolved. Needs review.

AnthonyLedesma commented 4 years ago

Working this one now.

jrtashjian commented 4 years ago

I'm not really understanding why the sniffs are failing in Travis-CI. An exclusion exists for the rule it's screaming about. @EvanHerman can you take a look at this?

EvanHerman commented 4 years ago

@jrtashjian I just went ahead and moved this all over to CircleCI. I think the issue was, the package we were using in travis (wp-dev-lib) wasn't recognizing our phpcs configuration file. Rather than digging into that and issuing a PR, I went ahead and just moved it all over to CircleCI.

I didn't setup Codeception on the CircleCI build because I figure we can eventually migrate over to Cypress.

Either way, I think this one is clear to merge 👍

jrtashjian commented 4 years ago

@EvanHerman Awesome, thank you!