search

godaddy-wordpress / primer-child-velux

Velux is a Primer child theme with a clean, professional, and upscale design.
13 stars 7 forks source link

Navigation links are pushed down in header #56

Closed cpharris closed 6 years ago

cpharris commented 6 years ago

Hello,

The logo is pushing the navigation links below the "site-title-wrapper" div.

I've tried adding and remove the Title and Tag Line but it doesn't seem to make a difference.

You can see it here: website example

And here's a screenshot from Chrome.

image

EvanHerman commented 6 years ago

Hi @cpharris

I'll do some testing to see if this is something occurring out of the box, or if there is a conflict with a plugin you have installed.

In the meantime, you should be able to fix the issue by dropping the following CSS snippet into the 'Additional CSS' section of the customizer.

.site-title-wrapper {
   width: auto;
}

I will report back here with some findings when I've had a moment to test.

Evan

cpharris commented 6 years ago

Excellent! Thank you Evan.

I added the width:auto CSS for now.

On Thu, Jan 18, 2018 at 9:32 AM Evan Herman notifications@github.com wrote:

Hi @cpharris https://github.com/cpharris

I'll do some testing to see if this is something occurring out of the box, or if there is a conflict with a plugin you have installed.

In the meantime, you should be able to fix the issue by dropping the following CSS snippet into the 'Additional CSS' section of the customizer.

.site-title-wrapper { width: auto; }

I will report back here with some findings when I've had a moment to test.

Evan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/godaddy/wp-velux-theme/issues/56#issuecomment-358663926, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8Fust6uHpyh-oF88EP-arIn--pKC4pks5tL1YVgaJpZM4Ri-i4 .

EvanHerman commented 6 years ago

Hi @cpharris

Glad to hear that worked for you! I did go ahead and do some testing and noticed the same issue on a fresh install with nothing else active.

I've gone ahead and issued a PR against our development branch so we can get this fix included in the next release of Velux. (See Issue #57)

Thanks so much for reporting the issue here. I'll leave this issue open so it doesn't fall through the cracks and so anyone else facing a similar issue can make note of the fix I've provided. When we get v1.1.2 pushed out, this fix will be included and the above CSS snippet will no longer be necessary.

Evan

cpharris commented 6 years ago

Good to hear! Thanks again!

On Thu, Jan 18, 2018 at 4:24 PM Evan Herman notifications@github.com wrote:

Hi @cpharris https://github.com/cpharris

Glad to hear that worked for you! I did go ahead and do some testing and noticed the same issue on a fresh install with nothing else active.

I've gone ahead and issued a PR against our development branch so we can get this fix included in the next release of Velux.

Thanks so much for reporting the issue here. I'll leave this issue open so it doesn't fall through the cracks and so anyone else facing a similar issue can make note of the fix I've provided. When we get v1.1.2 pushed out, this fix will be included and the above CSS snippet will no longer be necessary.

Evan

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/godaddy/wp-velux-theme/issues/56#issuecomment-358786277, or mute the thread https://github.com/notifications/unsubscribe-auth/AB8FukIdE_lH0l3hXxCKXRWLpUJ8xIfdks5tL7aKgaJpZM4Ri-i4 .