search

godaddy-wordpress / primer

Primer is a powerful theme that brings clarity to your content in a fresh design. This is the parent for all themes in the GoDaddy Primer theme family.
https://wordpress.org/themes/primer/
GNU General Public License v2.0
134 stars 36 forks source link

WooCommerce theme overrides featured-image header setting #298

Closed cgrayson closed 1 year ago

cgrayson commented 4 years ago

On sites using this theme and the WooCommerce plugin, posts' featured images are always shown in the header, even if the use_featured_hero_image setting is off.

nilshellerhoff commented 2 years ago

Can confirm this. The issue comes from here: https://github.com/godaddy-wordpress/primer/blob/45156b091c0162584c6e7d5ae9348a5911c3f858/inc/compat/woocommerce.php#L739

Apparently ! is_product() is always true when WooCommerce is active

aledesma-godaddy commented 1 year ago

Closing issues and PRs in preparation for repository archival