search

godaddy-wordpress / sake

Our internal build tool for WP/WC plugins
MIT License
4 stars 0 forks source link

Docs issue doesn't link to multi-plugin repo release issue #10

Closed tamarazuk closed 5 years ago

tamarazuk commented 6 years ago

I opened a docs issue in a deploy I did last week and just noticed that Sake didn't properly cite the related release issue for the multi-plugin repo:

skyverge/woocommerce-social-login#2383 should read skyverge/wc-plugins#2383

I have since fixed the Docs issue to reference the correct repo

rjfrizz commented 6 years ago

@tamarazuk one I found with the link missing: https://github.com/skyverge/wc-plugins-sales-docs/issues/677

tamarazuk commented 6 years ago

@rjfrizz did you mean https://github.com/skyverge/wc-plugins-sales-docs/issues/672?

tamarazuk commented 6 years ago

@unfulvio do you recall if you used Sake or Grunt when deploying COGs on Sept 5th? Did you run into any issues which required you to create a manual docs issue? Thanks :)

unfulvio commented 6 years ago

hey Tam, I can't remember if I had any issue with launching a docs task. I think I used Sake then. I had issues with Sake & Memberships which I hope they are fixed but usually for the wc-plugins sake worked ok. I see the docs issue created is missing something. I didn't pay attention to that, so I'm not sure now.

rjfrizz commented 6 years ago

@tamarazuk Yes, I did mean 672. My apologies. I was working on limited brain functionality at that point.

ragulka commented 5 years ago

@tamarazuk I just ran a full test on my forks of wc-plugins, woocommerce-gateway-usa-epay and wc-plugins-sales-docs and saw that the link to the release issue was created on the docs issue just fine:

Screenshot 2019-07-10 at 14 35 16 Screenshot 2019-07-10 at 14 35 30

Now, it could be that there was a glitch with this related to all the various octokit deprecation warnings during deploy, but I think the more likely explanation for the missing link would be that the deploy halted at some point and maybe the github:docs_issue task was manually run after that? If that's the case, then the release issue would need to be provided as an option, ie:

npx sake github:docs_issue --release_issue_to_close=22

Do you think this can be closed for now since I could not reproduce this?

tamarazuk commented 5 years ago

@ragulka I think this can be closed since we don't do release issues any more. I haven't done a deploy under the new process so I'm not sure if we're linking to the PR now, but that would be helpful