search

godaddy-wordpress / sake

Our internal build tool for WP/WC plugins
MIT License
4 stars 0 forks source link

Notify of updates when running sake #43

Closed ragulka closed 3 years ago

ragulka commented 5 years ago

Would it be helpful if we'd automatically check if a newer version (or commit) is available in the master branch when running npx sake and notify that on the CLI?

This would help prevent issues where the person doing the deploys is using an outdated version of Sake and any implications thereof.

I'm not sure if this would require starting versioning Sake or if we could simply check for newer commits from the master branch. Proper versioning would make it easier to determine what version/release of sake is being. Also, it could be beneficial to introduce a changelog along versioning.

In any case, at least a simple warning/notice would altready be helpful especially when doing deploys. Something like this:

$ npx sake deploy
A newer release of sake is available! Would you like to update now or skip?
[ ] Update and continue task
[ ] Skip and continue task
[ ] Review changes (open changelog in browser)
[ ] Cancel (stop current task, do nothing)
unfulvio commented 5 years ago

I second this, given also some recent hiccups on some less frequently updated free plugins on the Memberships Add Ons repository. It would help tracing back an issue by just comparing versions and version used by a plugin to deploy. In fact, maybe a commit message could also leave a "mark" about the Sake version used in the deploy/versioning commit message. Also for this reason I think versioning Sake is the easiest way to go.