godaddy-wordpress / sake

Our internal build tool for WP/WC plugins
MIT License
4 stars 0 forks source link

Remove end of line character from regular expressions #58

Closed wvega closed 3 years ago

wvega commented 4 years ago

Summary

This PR updates the regular expressions used to update the Tested up to and minimum required versions in plugin headers.

Story: CH 65812

QA

Confirm that sake works for Facebook for WooCommerce and one of our plugins.

Steps

Facebook for WooCommerce

  1. Update package.json to use version github:skyverge/sake#ch65812/remove-end-of-line-characters-from-some-regex of saké
  2. Run npm install sake
  3. Run npx sake fetch_latest_wp_wc_versions bump:minreqs --minimum_wp_version=4.5.0 --tested_up_to_wp_version=5.3.0 --tested_up_to_wc_version=4.0.0 --minimum_wc_version=4.0.0 --series
  4. Confirm that sake successfully set:
    • [x] The Minimum WP version header to 4.5.0
    • [x] The Minimum WC version header to 4.0.0
    • [x] The Tested up to header to 5.3.0
    • [x] The WC tested up to header to 4.0.0

Authorize.Net

  1. Update package.json to use version github:skyverge/sake#ch65812/remove-end-of-line-characters-from-some-regex of saké
  2. Run npm install sake
  3. Run npx sake fetch_latest_wp_wc_versions bump:minreqs --minimum_wp_version=4.5.0 --tested_up_to_wp_version=5.3.0 --tested_up_to_wc_version=4.0.0 --minimum_wc_version=4.0.0 --series
  4. Confirm that sake successfully set:
    • [x] The Minimum WP version header to 4.5.0
    • [x] The Minimum WC version header to 4.0.0
    • [x] The Tested up to header to 5.3.0
    • [x] The WC tested up to header to 4.0.0