search

godaddy-wordpress / wc-plugin-framework

The official SkyVerge WooCommerce plugin framework
Other
137 stars 42 forks source link

Expiration (MM/YY) cannot be translated #536

Open antedrnasin opened 3 years ago

antedrnasin commented 3 years ago

UPDATE: I got it to work. the only problem is the "Expiration (MM/YY)" text. It just doesn't work. My guess is that somewhere down the line, during parsing, the SLASH inside that variable is causing it not to be overridden.

unfulvio-godaddy commented 1 year ago

Hey @antedrnasin is this still an issue? If you are referring to this line in https://github.com/godaddy-wordpress/wc-plugin-framework/blob/b6a17bfc00443ceaa94a1ce8adfe666b15f3f32e/woocommerce/payment-gateway/admin/class-sv-wc-payment-gateway-admin-payment-token-editor.php#L574 it is wrapped in a WP gettext function with the woocommerce-plugin-framework and should be translatable like any other WP string in such context -- I notice however the placeholder attribute is not equally translated: is that the issue you are referring to?