godaddy-wordpress / wc-plugin-framework

The official SkyVerge WooCommerce plugin framework

Other

138 stars 42 forks source link

Mwc 15631/fix remove support #661

Closed nikolas4175-godaddy closed 4 months ago

nikolas4175-godaddy commented 4 months ago

Summary

Prevents remove_support() from erroneously removing the item at index 0 when $name is not found and also creating gaps in gateway supports array.

Slack discovery for context (s/o @sporter1-godaddy).

Issue: MWC-15631

QA

[ ] Attempting to remove an already-unsupported feature does not change the array
[ ] Removing supported features works as expected
[ ] When a feature is removed, the supports array is not left with any index gaps

nikolas4175-godaddy commented 4 months ago

Somehow mixed up the branch basing on this one, closing to resubmit rather than sorting through conflicts for such a small change.