godaddy-wordpress / wc-plugin-framework

The official SkyVerge WooCommerce plugin framework
Other
138 stars 42 forks source link

Update npm build packages #667

Closed unfulvio-godaddy closed 3 months ago

unfulvio-godaddy commented 3 months ago

Summary

This PR updates npm dependencies that are used in the FW to build its static assets, generate the potfile, compile scss and coffeescript, webpack, etc.

This should address some security warnings although the dependencies per se are not part of the distribution so there are no security risks involved.

I was hoping it would have addressed the issue with #360 however it turns out the output is still problematic and likely an issue with the grunt-contrib-sass package. I'll open an issue there to ask for configuration options (update: issue opened https://github.com/gruntjs/grunt-contrib-sass/issues/283).

For now I have manually edited the affected map file references, but there changes would be reverted if we are to build again those css files (does not happen that frequently).

Closes #360 (see above caveats though, will require follow up)

would also close several open prs: https://github.com/godaddy-wordpress/wc-plugin-framework/pulls?q=is:pr+is:open+sort:updated-desc

QA

To test these changes, the reviewer should run this version of the FW with a gateway that uses the payment form and account payment methods, ensuring the functionality and CSS is unaltered.