search

godaddy-wordpress / wc-plugin-framework

The official SkyVerge WooCommerce plugin framework
Other
138 stars 42 forks source link

Support core WP dismissible admin notices #93

Closed maxrice closed 8 years ago

maxrice commented 9 years ago

As of WP 4.2, core has dismissible admin notices -- much nicer: http://cl.ly/image/2m1g2b2J001L than our "dismiss" text.

Our existing admin notice handler should be updated to use those notices if WP >= 4.2 -- eventually we can remove our dismissible handling once WC core requires WP 4.2+

Also should change the default notice class to updated as right now it's an angry red which doesn't fit most of our usages where the notice is just a friendly "hey check this out" vs. "omg something's wrong"

justinstern commented 9 years ago

woot! It'd be huge to be able to cut the dismissible admin notice code out, that stuff was pretty complicated to implement, and more complicated to use than I would have liked