search

godaddy / compose-color-picker

Jetpack Compose Android Color Picker 🎨
MIT License
375 stars 23 forks source link

Add the ability to change color programmatically #27

Closed thadcodes closed 1 year ago

thadcodes commented 2 years ago

This should resolve issue #18, at least for the HarmonyColorPicker. It looks like the Classic one should already support programmatically updating itself.

ffgiraldez commented 2 years ago

Hi @thadcodes, sorry for the delay. I will look at those changes, but they look outstanding. Thanks.

thadcodes commented 2 years ago

@riggaroo Updated based on your feedback. Will open the brightness bar PR as soon as this is merged

thadcodes commented 2 years ago

Sorry @ffgiraldez I pushed my changes to the wrong branch that's why you are not seeing them, I'll have them up on the right branch.

I can see the argument on the Color Picker that programmatically updates. I actually wrote that when I was going to have two versions before just deprecating the old one. I am fine doing that as the comment should be in the deprecation warning now that they are not both correct versions

thadcodes commented 2 years ago

ok @ffgiraldez updated, sorry about the wasted review cycle. 🤦‍♂️

ffgiraldez commented 2 years ago

You probably will punch me, but please, could you update the example in the README to match real param names?

thadcodes commented 2 years ago

You probably will punch me, but please, could you update the example in the README to match real param names?

@ffgiraldez LOL no not at all, that's what I get for assuming IntelliJ would rename it here too and not checking. Fixed and pushed. Lucky you found that because I also had an error in the example that wasn't just renaming

ffgiraldez commented 2 years ago

@thadcodes LGTM now, I need to check why the signing is failing on CI😓

riggaroo commented 1 year ago

@thadcodes Thanks - that is fixed! 🎉 One last request - can you update ClassicColorPickerScreen for the desktop build as that is using the deprecated version?

thadcodes commented 1 year ago

@thadcodes Thanks - that is fixed! 🎉 One last request - can you update ClassicColorPickerScreen for the desktop build as that is using the deprecated version? @riggaroo sorry for the delayed response. This latest update should address your concerns

ffgiraldez commented 1 year ago

Waiting for #49 to merge this. Sorry for all of this @thadcodes