godaddy / datastar

A robust and feature rich ODM for Cassandra.
MIT License
40 stars 12 forks source link

Wrong Schema.prototype.sufficientRemoveConditions function #18

Open k1tzu opened 6 years ago

k1tzu commented 6 years ago

If 'key' is 0, for example uid: cql.int() and we try to remove uid = 0 like User.remove({uid: 0}); we get a false error in the function

Schema.prototype.sufficientRemoveConditions = function (conditions) {
  var keys = this.lookups
    ? Object.keys(this.lookupTables).concat(this.primaryKeys())
    : this.primaryKeys();

  return keys.every(function (key) {
    return !!conditions[key];
  });
};

"Must pass in all primary keys when using lookup tables"

jcrugzz commented 6 years ago

@k1tzu would love a pull-request to fix this issue! Great find