search

godaddy / ekke

Ekke is a test runner for React-Native, it allows you to execute your test code directly on the device enabling you to test in the same environment as your production users.
MIT License
133 stars 9 forks source link

Use a custom path for the Metro cache #19

Closed johman10 closed 5 years ago

johman10 commented 5 years ago

Fixes: https://github.com/godaddy/ekke/issues/11

This sets a custom cacheStore for Metro and allows the user to control it using the --cache-location flag. By default it will use the same location as Metro except for the last folder, which specifies the ekke-cache to keep them separate from each other.

Sidenote The documentation mentioned a --no-reset-cache flag, but I couldn't find any code related to it, so I'm assuming it was not actually working. That's why I inverted the documentation to reflect the actual new behaviour.

Acceptance Criteria

3rd-Eden commented 5 years ago

Thanks for taking the time to contribute 🎉 @Swaagie thoughts on the caching issue I mentioned above?

3rd-Eden commented 5 years ago

Forgot that @Swaagie is out for vacation, summoning magic-lamp @msluther for opinions/ review

3rd-Eden commented 5 years ago

Decided to merge it, so we can at least publish the fix. I'm going to address the cache-key issue with babel in my upcoming plugin release #17 which should hopefully fix most of the cache invalidation issues.

3rd-Eden commented 5 years ago

Thanks again for the PR <3

3rd-Eden commented 5 years ago

Released in 1.1.0