search

godaddy / kubernetes-client

Simplified Kubernetes API client for Node.js.
MIT License
961 stars 192 forks source link

Require node 12 #586

Closed bendrucker closed 4 years ago

bendrucker commented 4 years ago

This is a follow up to https://github.com/godaddy/kubernetes-client/pull/528#issuecomment-579661176. I'm hoping to update openid-client in order to resolve a deprecation warning:

(node:81223) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

This originates from timed-out:

kubernetes-client@8.3.6 /Users/ben/src/godaddy/kubernetes-client
└─┬ openid-client@2.5.0
  └─┬ got@8.3.2
    └── timed-out@4.0.1

Later versions upgrade got and in turn timed-out.

Because this change eliminates node 8 compatibility, it should be released as breaking (v9).

bendrucker commented 4 years ago

FWIW #528 already updates openid-client to a sufficient version. This just unpins it in addition to requiring node 12.

bendrucker commented 4 years ago

Not clear to me why scripts/test-generated.sh is failing. Don't have time to dig into it now, mainly wanted to open this to initiate discussion on the next release.

bendrucker commented 4 years ago

Had to regenerate typings to get tests passing. Assuming that has something to do with node 12, but not sure exactly what.

silasbw commented 4 years ago

Thanks! Made some tweaks to keep support for 10: https://github.com/godaddy/kubernetes-client/pull/592

bendrucker commented 4 years ago

Thank you so much! Will look out for a release soon.