search

godaddy / svgs

svgs is a compatiblity layer between svg and react-native-svg
MIT License
191 stars 31 forks source link

proper default for preseveAspectRatio #21

Closed 3rd-Eden closed 6 years ago

3rd-Eden commented 6 years ago

[deps] Updated dependencies [test] Update to latest enzyme [test] Added coverage reporting [fix] Added default for presevereAspectRatio

ganmor commented 6 years ago

This prevent from being able to stretch an svg : preventAspectRatio="none" get prefixed to default "xMidYMid none" preserveAspectRatio="none none" does not work in chrome.

Maybe I am missing something her but I could get chrome to stretch my svg.

( It works as expected in react native )

3rd-Eden commented 6 years ago

@ganmor Thanks for pointing that out, I'll add a special cause for none and should be fixed in the next minor release.

3rd-Eden commented 6 years ago

@ganmor Fixed in 3.2.1, apologies for the inconvenience that this has caused.