godamartonaron / GODA_pyPPG

pyPPG v01
HomePage
Other
28 stars 9 forks source link

Issues about fiducial point detection #15

Closed zhaodongsun closed 4 months ago

zhaodongsun commented 4 months ago

Hi, thanks for this nice work. When I use pyPPG to detect fiducial points from a PPG signal, there are no fiducial points detected at the end. The figure below shows the issue. The PPG signal is 60Hz. Does the sampling rate cause the issue? How to fix it?

image

zhaodongsun commented 4 months ago

Here is another example. image

godamartonaron commented 4 months ago

To the onset detection algorithm, a given time window is necessary, therefore you can't see the other fiducial points at the end of the record.

zhaodongsun commented 4 months ago

Thanks for your reply!