search

godarch / darch

A tool for building and booting stateless and immutable images, bare metal.
https://godarch.com/
MIT License
831 stars 32 forks source link

Enable cryptodisk #28

Closed shizonic closed 6 years ago

shizonic commented 6 years ago

For encrypted devices the grub environment variable GRUB_ENABLE_CRYPTODISK has to be set to y in order to generate the correct grub entry. If this environment variable isn't set the essential part of cryptomount -u is missing.

pauldotknopf commented 6 years ago

Have you verified this works with non-encrypted boot volumes?

shizonic commented 6 years ago

No not yet, but I can if you suggest. Another option would be an additional cli flag and a condition. I may work on this if you like. I want also add a flag for a custom configPath (/etc/darch).

EDIT: But as far as I know GRUB_ENABLE_CRYPTODISK does only be used by GRUB if you really have an encrypted boot partition. However I will confirm that if I have tested it.

pauldotknopf commented 6 years ago

Thanks! Let me know the results. I'm fine with a cli flag.

shizonic commented 6 years ago

Any suggestions?

pauldotknopf commented 6 years ago

LGTM

pauldotknopf commented 6 years ago

I've deployed 0.21.0, glad you got everything working!

shizonic commented 6 years ago

Thank you @pauldotknopf for merging and that you are satisfied with my little contibution. I would like to help out more if you are interested. Thanks too for the deployment of release 0.21.0. Are planning to update the void package too?