godarklight / DarkMultiPlayer

DarkMultiPlayer - A multiplayer mod for Kerbal Space Program
MIT License
280 stars 120 forks source link

Planned maneuver nodes are saved to the server but not loaded #388

Closed 81ninja closed 7 years ago

81ninja commented 7 years ago

Intentionally:

VesselWorker.cs:
private ProtoVessel CreateSafeProtoVesselFromConfigNode(ConfigNode inputNode, Guid protovesselID)
        {
            ProtoVessel pv = null;
            try
            {
                DodgeVesselActionGroups(inputNode);
                RemoveManeuverNodesFromProtoVessel(inputNode);

However I don't see the reason why this is. I've commented that line out and nobody died, nothing crashed, and maneuvers are correctly loaded. Does that have any side effects? Am I missing something?

Xinayder commented 7 years ago

I don't know why we remove them from the vessel, but if nothing broke if you commented that line, I think we're good to go to remove it. Let me know if hell breaks loose because of that.

81ninja commented 7 years ago

Fixed on master by b9bc0d3