search

godarklight / DarkMultiPlayer

DarkMultiPlayer - A multiplayer mod for Kerbal Space Program
MIT License
280 stars 120 forks source link

-Changed CompatibilityChecker.cs to allow Kerbal Space Program Versio… #410

Closed PhilG0lding closed 7 years ago

PhilG0lding commented 7 years ago

For KSP version 1.2.9

-Updated CompatibilityChecker.cs and DisclaimerWindow.cs to fix build errors related to PopupDialog (invalid overload?)

Xinayder commented 7 years ago

The reason why we haven't changed to 1.2.9 is because 1.2.9 is a pre-release version. Anyway, why the changes to the dialogs?

PhilG0lding commented 7 years ago

I created this as a group of people were hoping to use it on pre-release (And then on release). I was hoping that it would be added to a new branch, perhaps "Pre-release" and people can put similar changes through in future.

Changes to dialogs, looks like Assembly-CSharp.dll now requires a Dialog name in the constructor parameters, which I've added.

godarklight commented 7 years ago

I've no problem with supporting this, as it will almost certainly require no changes to 1.3.0, and it is available publicly.

My big question is where do these KSP versions keep coming from with no dev team? :P

Xinayder commented 7 years ago

Fixed via ac91be7b647adaaf8f64d093abd043cbdcb8dc3e