godarklight / DarkMultiPlayer

DarkMultiPlayer - A multiplayer mod for Kerbal Space Program
MIT License
280 stars 120 forks source link

KSP 1.3.1 Support #430

Closed d4rkd0s closed 6 years ago

d4rkd0s commented 6 years ago

image

Environment

Windows 10 x64

Description

Plugin no longer launches with new KSP Version.

Additional Info

Nothing else really needed, mod just needs some testing and a version bump.

d4rkd0s commented 6 years ago

Think we need to bump this to 1? https://github.com/godarklight/DarkMultiPlayer/blob/99bca17078a351683aded1f431d44875d32951bf/Client/Utilities/CompatibilityChecker.cs#L53

Xinayder commented 6 years ago

In short, yes. Long version: we need to check if there were any breaking changes in 1.3.1, check the API changes, modify our current code if necessary and then release a new version.

I'm surprised as to why people quickly want to file an issue when there's a self-explanatory text that tells you why it's not working

d4rkd0s commented 6 years ago

@RockyTV Apologies for the confusion, wasn't complaining or filing a "bug" issue, just want to get the work done to get DMP back up n' running for KSP 1.3.1.

First of, it appears raw changes to the "game" are (source):

As for the API changes, I am not familiar enough with KSP API to determine/find a changelog.

Next I am going to fork and make changes to this line and test. https://github.com/godarklight/DarkMultiPlayer/blob/99bca17078a351683aded1f431d44875d32951bf/Client/Utilities/CompatibilityChecker.cs#L53

Xinayder commented 6 years ago

No need to, check the unstable branch. I pushed some pending PRs and if you want to test the changes, feel free to do so. Any feedback is appreciated.

d4rkd0s commented 6 years ago

Thanks very much @RockyTV