search

godatadriven / databricks-cdk

Deployment of databricks resources with cdk
MIT License
8 stars 7 forks source link

Retrieve token_value from Token construct #819

Closed DaanRademaker closed 1 year ago

DaanRademaker commented 1 year ago

Currently I am not able to get the generated token_value from the Construct. Looking at for example the credentials construct I see that there is a public function attached to return attribute string. Would this be required for token too?

DaanRademaker commented 1 year ago

See pull request: https://github.com/godatadriven/databricks-cdk/pull/818

ffinfo commented 1 year ago

since it's a secure string this should never be done in plain text. Must be stored in parameter store of secret manager from the deploy lambda

DaanRademaker commented 1 year ago

Fair enough. I will think of some way to use this with secrets.

DaanRademaker commented 1 year ago

I don't seem to be able to create a param with a secure string, this is not possible in cloudformation templates. https://docs.aws.amazon.com/cdk/api/v2/python/aws_cdk.aws_ssm/README.html#creating-new-ssm-parameters-in-your-cdk-app

DaanRademaker commented 1 year ago

So only option would be to use secret manager directly.

ffinfo commented 1 year ago

fixed by #911