search

godatadriven / evol

a python grammar for evolutionary algorithms and heuristics
https://evol.rtfd.io
MIT License
187 stars 12 forks source link

WIP: Change the signature of pick_random #155

Open rogiervandergeer opened 4 years ago

rogiervandergeer commented 4 years ago

Parent pickers are no longer passed any kwargs. The pick_random must now be initialised before use, the number of parents passed to it upon initialization. In addition, pickers must always return a sequence of picked parents - even if it is only one.

These changes make it much easier to implement more complex picking algorithms, and in addition they remove the requirement for the select_arguments() decorator, which hurts my eyes.

koaning commented 4 years ago

This does feel like a breaking change. Might a deprecation warning be a nice thing to add here?

rogiervandergeer commented 4 years ago

This does feel like a breaking change. Might a deprecation warning be a nice thing to add here?

It is certainly is a breaking change. Hence it would probably be best to only publish this in v2.0. Adding a deprecation warning here doesn't make much sense: you'd be saying "this isn't going to work in the future, but you cannot do anything about it right now".

koaning commented 4 years ago

I can live with that. But since we're not at version 1 yet, is there a reason you immediately want to jump to 2?

rogiervandergeer commented 4 years ago

Oops, I thought we were… Let’s call it 1.0 then 😊

On 18 May 2020, at 09:28, vincent d warmerdam notifications@github.com<mailto:notifications@github.com> wrote:

I can live with that. But since we're not at version 1 yet, is there a reason you immediately want to jump to 2?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/godatadriven/evol/pull/155#issuecomment-629997551, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZ5BBAPTLOF5NTJGMZDXM3RSDPRFANCNFSM4NBZU7ZA.

koaning commented 4 years ago

@rogiervandergeer are there other changes we'd like to make for version 1? I mean ... version 1 is a milestone release.

koaning commented 4 years ago

One thing that I've been wondering about is that we may then also submit evol to this: https://joss.theoj.org/

rogiervandergeer commented 4 years ago

I guess! Let’s not release anything yet 😊

On 18 May 2020, at 10:17, vincent d warmerdam notifications@github.com<mailto:notifications@github.com> wrote:

@rogiervandergeerhttps://github.com/rogiervandergeer are there other changes we'd like to make for version 1? I mean ... version 1 is a milestone release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/godatadriven/evol/pull/155#issuecomment-630022440, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZ5BBDHFY5PQQ6FCTIG3TTRSDVKJANCNFSM4NBZU7ZA.