godatadriven / pydantic-avro

This library can convert a pydantic class to a avro schema or generate python code from a avro schema.
https://github.com/godatadriven/pydantic-avro
MIT License
63 stars 30 forks source link

Add support for array of arrays #82

Closed timvancann closed 1 year ago

timvancann commented 1 year ago

The structure for an array of arrays as it is currently rendered is not supported by fastavro. This PR fixes this nested structure such that pydantic models with list of lists can be parsed into an avro schema correctly.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13 :tada:

Comparison is base (705dc7c) 90.59% compared to head (70e83c7) 90.73%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== + Coverage 90.59% 90.73% +0.13% ========================================== Files 2 2 Lines 202 205 +3 ========================================== + Hits 183 186 +3 Misses 19 19 ``` | [Impacted Files](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven) | Coverage Δ | | |---|---|---| | [src/pydantic\_avro/base.py](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven#diff-c3JjL3B5ZGFudGljX2F2cm8vYmFzZS5weQ==) | `98.03% <100.00%> (+0.05%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.