search

godatadriven / pydantic-avro

This library can convert a pydantic class to a avro schema or generate python code from a avro schema.
https://github.com/godatadriven/pydantic-avro
MIT License
63 stars 30 forks source link

Add support for pydantic v2 #91

Closed sharonyogev closed 1 year ago

sharonyogev commented 1 year ago

This add support for pydantic v2 without dropping support to pydantic v1 I would love this to be merged soon so I can upgrade pydantic in my project

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.38% :tada:

Comparison is base (e7968b4) 90.73% compared to head (3a38fe1) 91.12%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ========================================== + Coverage 90.73% 91.12% +0.38% ========================================== Files 2 2 Lines 205 214 +9 ========================================== + Hits 186 195 +9 Misses 19 19 ``` | [Files Changed](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven) | Coverage Δ | | |---|---|---| | [src/pydantic\_avro/base.py](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/91?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven#diff-c3JjL3B5ZGFudGljX2F2cm8vYmFzZS5weQ==) | `98.19% <100.00%> (+0.15%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DaanRademaker commented 1 year ago

Looking pretty good to me. Will ask some feedback from other maintainers as well. For now, the isort check is failing so that needs to be fixed.

sharonyogev commented 1 year ago

Thanks, updated the isort problem 🙏 BTW, note that since I added the pydantic-version to the version matrix, it failed to find the required check

sharonyogev commented 1 year ago

Great, thank you very much for the really quick response 🙏🙏🙏 Do you guys knows when are you planning on release a new version of the package?

timvancann commented 1 year ago

@sharonyogev Just made a new release for you. https://pypi.org/project/pydantic-avro/

sharonyogev commented 1 year ago

@timvancann I think you force push some commits that removed this merged PR... Can you check, if you want me to rebase and re-open the PR tell me