search

godatadriven / pydantic-avro

This library can convert a pydantic class to a avro schema or generate python code from a avro schema.
https://github.com/godatadriven/pydantic-avro
MIT License
60 stars 30 forks source link

Feature/pydantic v2 restore #92

Closed sharonyogev closed 1 year ago

sharonyogev commented 1 year ago

@timvancann Hi, as I said in https://github.com/godatadriven/pydantic-avro/pull/91 I think those commits have lost in some bad force-push or something like this... Do you want to restore them yourself, or merge this PR?

Contains the relevant PRs: https://github.com/godatadriven/pydantic-avro/pull/91 https://github.com/godatadriven/pydantic-avro/pull/82

Ignored those PR (since you edit the same files later): https://github.com/godatadriven/pydantic-avro/pull/83 https://github.com/godatadriven/pydantic-avro/pull/84

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.52% :tada:

Comparison is base (393c50a) 90.59% compared to head (c7aa47a) 91.12%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #92 +/- ## ========================================== + Coverage 90.59% 91.12% +0.52% ========================================== Files 2 2 Lines 202 214 +12 ========================================== + Hits 183 195 +12 Misses 19 19 ``` | [Files Changed](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven) | Coverage Δ | | |---|---|---| | [src/pydantic\_avro/base.py](https://app.codecov.io/gh/godatadriven/pydantic-avro/pull/92?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=godatadriven#diff-c3JjL3B5ZGFudGljX2F2cm8vYmFzZS5weQ==) | `98.19% <100.00%> (+0.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

timvancann commented 1 year ago

No clue what happened. It wasn't intentional in any case. I'll merge this one again.

sharonyogev commented 1 year ago

Great thanks! So now we just need to bump another version so it will be published, right?