search

godbasin / angular-select2

select2 in angular(>=2.0-release).
MIT License
15 stars 11 forks source link

Bundle for js #34

Closed mark-bradshaw closed 2 years ago

mark-bradshaw commented 6 years ago

I'm opening a new PR because #33 was closed out.

When you're trying this one, please do npm install before npm run build.

NOTE, you WILL see errors. That's because there are issues in your code that the typescript linter doesn't like. However, this won't affect the compilation. You should see a new dist folder created that has the javascript code in it, and it should be ready for publication.

mark-bradshaw commented 6 years ago

I just pushed a new commit that remove the .npmignore file. That was messing up publish.

mark-bradshaw commented 6 years ago

Looks like you've already started working on it. You'll want to remove the .npmignore file before you try to publish.

mark-bradshaw commented 6 years ago

I see also now that the build is not including the select2 js you manually dropped in. I'll need to fix that.

mark-bradshaw commented 6 years ago

I just pushed up a change on build so that it copies over the needed js for select2 into the dist folder

mark-bradshaw commented 6 years ago

And another change. I just realized that the dependencies I thought were build dependencies aren't, and they are causing project conflicts, so I remove them.

mark-bradshaw commented 6 years ago

Hang off on all this. I'm finding issues that need addressing. I'm going to go and work on this, and come back with something that works. :/