Read email addresses, phone numbers, postal addresses and instant messaging

goderbauer / contact_picker

A Flutter plugin for picking a contact from the address book.

BSD 3-Clause "New" or "Revised" License

77 stars 109 forks source link

Read email addresses, phone numbers, postal addresses and instant messaging #9

Open ened opened 6 years ago

ened commented 6 years ago

the example now links to the simple_permissions plugin in order to gain access to the users address book
the dart class now returns a new data structure

rodydavis commented 6 years ago

Very nice!

ened commented 6 years ago

BTW, just noticed I left a incorrect simple_permissions dependency in there. Once https://github.com/Ethras/flutter_simple_permissions/pull/19 is merged and a new plugin version is released, I will update the PR.

rodydavis commented 6 years ago

Sounds great. I had been using a custom contact service plugin and it was such a pain and hack to do what I was wanting with this plugin

rodydavis commented 6 years ago

@ened I have actually had better luck with simple_permissions instead of flutter_simple_permissions btw

ened commented 6 years ago

@AppleEducate I believe those two are the same.

rodydavis commented 6 years ago

@ened I took what you did on your fork and merged the fields from flutter_contacts and updated the example. what do you think? https://github.com/AppleEducate/contact_picker

goderbauer commented 6 years ago

Very cool! I'll probably get around to review the code on the weekend.

ened commented 6 years ago

@AppleEducate not sure yet - what is the intention of removing ims, for example? I'd be happy to work on this PR first while keeping the changes as generic as possible.

@goderbauer Do you have comments?

rodydavis commented 6 years ago

@ened I can try to add it back but it was throwing Everytime a IMS returned with data when I selected a contact. If it was null it didn't crash. It is a weird bug.

I'll clean up the PR

ened commented 6 years ago

@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August.

rodydavis commented 6 years ago

Will do. It was also happening on you version too. I will try to find verbose logs because when it happens it does not provide any debug or crash info and just says lost connection to device. If you select a contact without IMS it doesn't crash. I'll keep exploring it

@AppleEducate please explain the crash a bit more in detail, and perhaps post a stack trace. I can look at it in early August. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

GroovinChip commented 5 years ago

Is this pull request ever going to be merged?

guyzk commented 5 years ago

@ened @goderbauer Is this plugin ever going to get updated? This is a very needed feature by several apps i believe. It would be most appreciated if you could merge this pull request and fix the androidX support. Thanks!

rodydavis commented 5 years ago

I’ve been a using my dependency override for quite some time now

dexcell commented 5 years ago

I personally oppose this pull request, the beauty of this plugin is to pick your contact without any permission.

I think it's better to create different/separate plugin if you need more detail about the contact with permission.

rodydavis commented 5 years ago

I’ll make a separate plugin then, thank you

guyzk commented 5 years ago

I’ll make a separate plugin then, thank you

Waiting for an update!!! Thanks!

rodydavis commented 5 years ago

@guyzk in the mean time you can use my fork of this plugin! I am already doing this