search

godjuansan / pe

0 stars 0 forks source link

Feature unblacklist #1

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

Feature blacklist should only be for blacklisting contact and the command to unblacklist a contact should be separated from it

nus-pe-bot commented 3 years ago

Team's Response

This is explained in the DG. image.png

While both implementations are viable and it may be argued that the current implementation is not the best, it is also not clearly worse than Alternative 2. As such, one of them had to be chosen and it was Alternative 1.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This does not make sense as in this case, in order to correctly blist a contact you need to check exactly what its current state is (whether it is currently blacklisted or not).

Clearly, this case is more extendable as the pros in the first alternative is not really a pro as it might make you accidentally change into a wrong state due to not checking what the current state is.