godjuansan / pe

0 stars 0 forks source link

`Undo` command #12

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

It is stated in the UG that This command only applies to the commands that make changes to the list of contacts, e.g. add , edit , delete etc. but it undo sort ascending which doesn't make changes to list of contacts while not undoing find m/phone treu.

Screenshot from 2021-04-16 15-11-24.png Screenshot from 2021-04-16 15-11-34.png Screenshot from 2021-04-16 15-11-40.png

nus-pe-bot commented 3 years ago

Team's Response

Sort does change the order of the list, which in turn changes addressbook.json, meanwhile the find command does not change addressbook.json. In particular, it does not make sense to change the internal list entirely for the find command since the user will still need the data after the user is done with the command.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: There are a lot of application where the find command is part of the undo. Furthermore, it is not clear that the meaning of make changes to the list of contacts is changing the addressbook.json. This could interpret to many things. For instance, making changes to the current shown list of contacts in the SpamEZ.

In any case, it is unclear which command exactly does undo command preserve and since find should be part of the undo command, I disagree.