godjuansan / pe

0 stars 0 forks source link

`Sort` descending #13

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

sort descending allows me to sort descending when the order is already descending. A message stating that the list is already descending should be popped out instead.

nus-pe-bot commented 3 years ago

Team's Response

Reason for marking as duplicate: Both issues are based on the fact that the sort command does not first "check" if the list is already sorted before sorting the list. Thus if I were to modify the internal implementation of the sort command to give the outcome desired by the tester for this issue, the other issue will also be addressed automatically. (i.e. One issue cannot be addressed independently from the other)

In addition, the reason that I will give for rejecting both issues (as well as changing severity to very low) are identical. Please refer to the original issue for more information.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Sort ascending

sort ascending allows me to sort ascending when the order is already ascending. A message stating that the list is already ascending should be popped out instead.


[original: nus-cs2103-AY2021S2/pe-interim#1105] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Reason for rejection : A list that is already sorted in ascending order can most certainly be sorted in ascending order again. (Just that no change will occur) This behaviour does not contradict what is stated in the user guide and it is unclear how this behaviour will hinder the user from using the software. Thus it seems to me that you are simply suggesting a quality-of-life change to the product.

Reason for downgrading severity to very low: This behaviour does not hinder the user from using the app.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: It is a different feature compared to this one and hence is not duplicate


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The user should know if this is already sorted descendingly.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]