search

godjuansan / pe

0 stars 0 forks source link

`Developer Guide` bug : Logic Component #16

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

Missing UIAction and UIActionOption which LogicManager should depend on. Screenshot from 2021-04-16 15-22-19.png

nus-pe-bot commented 3 years ago

Team's Response

In the following screenshot, it is clear that UIAction is a class that resides in Java library.

image.png

Hence, it does not make sense to include such classes in the class diagram. For example, classes such as ArrayList is not included in the diagram.

This is also not a native class in our code as shown in the following screenshot.

image.png

Thus, the class is omitted for brevity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In my team, both UIAction and UIActionOption is not omitted for "brevity". Everything inside the Logic folder must be included and for that reason I disagree.