godjuansan / pe

0 stars 0 forks source link

Phone number is allowed to be much more than 10 digits #6

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

No details provided. Screenshot from 2021-04-16 14-34-20.png

nus-pe-bot commented 3 years ago

Team's Response

See response for #1604.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Phone number does not have maximum digit limit

There is no maximum digit limit on the phone number, although there is a minimum digit limit.

This could allow for an extremely long phone number which will block out details being shown within a single page before scrolling.

image.png

This happens for both add and edit commands.


[original: nus-cs2103-AY2021S2/pe-interim#1604] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This does not contradict the user guide nor hinder the tester's experience. There is no problem with allowing long phone numbers, especially since anyone putting in long phone numbers has the intention of doing so.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Clearly putting 100 digit of phone numbers does not make sense and this is a FeatureFlaw and is a valid bug.


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: This is more than just severity VeryLow as it is not just pure cosmetic as described in severity VeryLow