search

godjuansan / pe

0 stars 0 forks source link

Allows me to add a remark with the name `No remark` #9

Open godjuansan opened 3 years ago

godjuansan commented 3 years ago

remark 5 r/No remark does not return error

nus-pe-bot commented 3 years ago

Team's Response

"No remark" is simply the default remark assigned to all newly added contacts. The reason why the remark command comes with the ability to remove the remark from a contact (via remark INDEX r/) is so that the user can remove the remark quickly. (Imagine how cumbersome it will be if the user had to use remark INDEX r/No remark every single time he wanted to remove a remark)

Thus, if the user wants to manually "remove" the remark from a person by inputting remark 5 r/No remark, then he is certainly welcome to do so. This behaviour does not contradict the user guide and also does not hinder the user from using the software in any way.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Suppose I am a user who keys in this. Then I will have no method to differentiate whether it is a remark named 'No Remark' or it is someone without a remark.

One possible better implementation is to have the real no remark colored differently than those having remark