search

godong9 / solr-node

Simple Solr Node Client Project.
MIT License
25 stars 25 forks source link

Please, publish a new version to npm #69

Closed carstenhag closed 6 years ago

carstenhag commented 6 years ago

Experienced a bug caused by the following, now outdated lines.
See https://github.com/godong9/solr-node/pull/64/commits/79d72edb3198f6011f6b644bbf579dcf402f8f75 for the change where this bug was fixed.

    try {
      result = JSON.parse(body);
      return finalCallback(null, result);
    } catch(e) {
      return finalCallback(null, body);
    }

After parsing the body, the callback is returned. If there's an error in finalCallback, the method catches the exception but returns another callback.

PR #64 fixed this bug. Could you please submit a new version of this package to npm?

godong9 commented 6 years ago

Sorry, I forgot that. Today, I will publish new version.

godong9 commented 6 years ago

Publish completed!