add solr basic auth - Githubissues

godong9 / solr-node

Simple Solr Node Client Project.

MIT License

25 stars 25 forks source link

Closed lvenier closed 5 years ago

lvenier commented 5 years ago

Add optionnal user and password to solr client creation

godong9 commented 5 years ago

This feature is breaking changes. Need to consider backwards compatibility.

lvenier commented 5 years ago

Do you want me to check backwards compatibility and update the PR ?

godong9 commented 5 years ago

Yes. Please check backwards compatibility and update.

lvenier commented 5 years ago

@godong9 : I have updated the Pr and fixed the backward compatibility. pls review.

I think we should add 2 new unit test :

Opinion pls.

godong9 commented 5 years ago

@lvenier Thanks to your contribution. 👍 I agree your opinion that is need to 2 new unit test. Please write unit test and update.

lvenier commented 5 years ago

@godong9 : You're welcome ! ;)

As discussed I have added 2 unit tests. Minimalist but doing the job.

Pls consider update README or doc with new user and password settings.

pls review.

lvenier commented 5 years ago

@godong9 : any comment ?

godong9 commented 5 years ago

This is good. I will release today. Thanks. 👍