search

godot-escoria / escoria-issues

Central Escoria issue tracker
3 stars 0 forks source link

Empty events aren't flagged as an error #175

Open balloonpopper opened 2 years ago

balloonpopper commented 2 years ago

Describe the bug As you can see from the below text from (worker.esc)[https://github.com/godot-escoria/escoria-demo-game/blob/develop/game/rooms/room06/esc/worker.esc], the "use r5_filled_sheet" event is empty.

If you try and use the sheet on the worker, nothing happens. 

:use r5_filled_sheet
#jump give r5_filled_sheet

####################################################################################################
:give r5_filled_sheet
set_gui_visible false
accept_input SKIP

To Reproduce Steps to reproduce the behavior:

  1. Create a script like the above

Expected behavior An empty event error message

Screenshots

Versions

Additional context Log

2022-3-8T211630 (I) Inventory item focused r5_filled_sheet  []
2022-3-8T211631 (I) Inventory item left clicked r5_filled_sheet     []
2022-3-8T211631 (I) esc_action_manager.do(): item_left_click on item    [r5_filled_sheet]
2022-3-8T211631 (I) r5_filled_sheet left-clicked with event     [[InputEventMouseButton:15309]]
2022-3-8T211631 (I) Activated action use on [Node:13168]    []
2022-3-8T211631 (I) Inventory item unfocused    []
2022-3-8T211631 (I) Item focused:   [r6_r_exit]
2022-3-8T211631 (I) Item focused:   [r6_r_exit_closed]
2022-3-8T211631 (I) Item unfocused:     [r6_r_exit]
2022-3-8T211631 (I) Item unfocused:     [r6_r_exit_closed]
2022-3-8T211631 (I) Item focused:   [worker]
2022-3-8T211632 (I) Item left clicked   [worker, [InputEventMouseButton:15637]]
2022-3-8T211632 (I) esc_action_manager.do(): item_left_click on item    [worker]
2022-3-8T211632 (I) worker left-clicked with event      [[InputEventMouseButton:15637]]
2022-3-8T211632 (D) player arrived at worker    
2022-3-8T211632 (I) Context arrived: [Object:15640]     []
2022-3-8T211632 (I) Context arrived: [Object:15640]     []
2022-3-8T211632 (I) Activated action use on [Node:13168]    []
2022-3-8T211632 (D) esc_event_manager   [Popping event use r5_filled_sheet from background queue _front]
2022-3-8T211632 (D) Event use r5_filled_sheet started   
2022-3-8T211632 (D) Event use r5_filled_sheet ended with return code 0
dploeger commented 2 years ago

Yes, this is cosmetics IMHO, so i'll set it to future.