godot-escoria / escoria-issues

Central Escoria issue tracker
3 stars 0 forks source link

Resetting text_lang / voice_lang results in them disappearing #294

Open balloonpopper opened 2 years ago

balloonpopper commented 2 years ago

Describe the bug The current text_lang and voice_lang settings in the main Escoria settings page are set to "fr_FR". If you use the reset button (arrow) in the menu settings to reset them, they reset to "null". This results in the menu options disappearing from Godot's Escoria main settings page.

To Reproduce Steps to reproduce the behavior: 1) Click the reset arrow next to text_lang / voice_lang in Godot (Escoria main) settings

Expected behavior They should reset back to potentially "en_EN" if English is chosen to be the default, or they should go to "unset" or similar.

Screenshots Before : image

Missing settings : image

Git diff image

Versions

Additional context Add any other context about the problem here.

BHSDuncan commented 1 year ago

cc @StraToN

It appears as though we aren't registering things quite correctly. In the core's plugin.gd, we call ProjectSettings.set_setting but this doesn't actually set a default value. We also need to add a call to ProjectSettings.set_initial_value, and possibly

I'll put this in, but I believe the project.godot file may need some cleaning. We can look at that in the PR, though.

BHSDuncan commented 1 year ago

https://github.com/godotengine/godot/issues/56598 we might not be able to do anything about this for the time being.

@StraToN @balloonpopper either we take another route or we remove this ticket from 4.0. Thoughts?

balloonpopper commented 1 year ago

Removed from 4.0